Skip to content

GH-8583: Add Java & DSL samples into docs #8608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2023

Conversation

artembilan
Copy link
Member

Fixes #8583

When users jump into docs first thing these days they expect to see a Java DSL sample.

Fixes spring-projects#8583

When users jump into docs first thing these days they expect to see a Java DSL sample.
Copy link
Contributor

@garyrussell garyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just docs, but also a couple of suggestions about adding links.

Co-authored-by: Gary Russell <[email protected]>
@artembilan
Copy link
Member Author

Gary, I applied your changes, but what link do you talk about?

And, please, hold off the merge yet: I missed to add samples into the router doc.

@garyrussell
Copy link
Contributor

garyrussell commented May 1, 2023

Two places:

suggestion
See more information about Java, Kotlin and Groovy DSLs in the respective chapters.

Add links to those chapters?

* Add links to DSL chapters
@artembilan artembilan requested a review from garyrussell May 1, 2023 20:38
@garyrussell garyrussell merged commit 33d13a4 into spring-projects:main May 1, 2023
@artembilan artembilan deleted the Gh-8583 branch May 2, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Java and DSL samples to general docs for Service Activator, Transformer, Splitter etc.
2 participants