Skip to content

Add ObservationRegistry option to JmsListenerContainerSpec #8742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nightswimmings
Copy link

@pivotal-cla
Copy link

@nightswimmings Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot review this without signed CLA.
Plus I believe we need some test verification in the JmsTests to be sure that this observation configuration has an effect on the flow.

Thanks

@artembilan
Copy link
Member

Any update here, please?
Or we will have to close this according to our policy and someone else can pick it up.

Thanks for understanding

@artembilan
Copy link
Member

Superseded with #8764

@artembilan artembilan closed this Oct 13, 2023
@artembilan artembilan added the status: invalid Not reproducable or not relevant to the current state of the project label Oct 13, 2023
@nightswimmings
Copy link
Author

Im really sorry, I jsut saw this, I thought it was abandoned as another user said in another issue that he would take care of the issue because it was related to other considerations. I can't find the comment though (was it deleted on the mother issue?)

@artembilan
Copy link
Member

@nightswimmings ,

There was no such a comment: only your this PR.

We were a bit short in time for yesterday's release, so I decided to fix it my own.

You always can look into our backlog to work on something what is interested for you.

Thank you for your effort anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid Not reproducable or not relevant to the current state of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants