Skip to content

Favor Composition in CompareFilter #1060

Closed
@jzheaux

Description

@jzheaux

CompareFilter uses a combination of composition and inheritance that implicitly encourages changing the object's behavior after construction time.

We can clean this up by deprecating getCompareString and getEncodedValue and requiring those in a protected constructor. In this way, all the data that CompareFilter needs is in final fields.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions