Skip to content

Support IP whitelist for Spring Security Webflux #10007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support IP whitelist for Spring Security Webflux #10007

wants to merge 1 commit into from

Conversation

terminux
Copy link
Contributor

Closes gh-7765

I extracted the matches method from IpAddressMatcher into InetAddressMatcher for reuse in HttpServletRequest and ServerWebExchange:

public boolean matches(String address)

@pivotal-cla
Copy link

@terminux Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@terminux Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 27, 2021
@sjohnr sjohnr self-assigned this Nov 16, 2021
@sjohnr
Copy link
Contributor

sjohnr commented Nov 16, 2021

Hi @terminux. We're beginning to work through our backlog of issues and PRs in preparation for the 5.7 development cycle. Are you able to work through a few rounds of feedback on this PR?

If so, the first thing would be to rebase on main, which has been upgraded to Java 17 and the jakarta.servlet namespace (from javax.servlet). I believe that's mostly the only conflict on this branch.

@terminux terminux force-pushed the gh-7765 branch 2 times, most recently from ba7e0d2 to 854d80b Compare November 18, 2021 04:17
@terminux
Copy link
Contributor Author

Hi @terminux. We're beginning to work through our backlog of issues and PRs in preparation for the 5.7 development cycle. Are you able to work through a few rounds of feedback on this PR?

If so, the first thing would be to rebase on main, which has been upgraded to Java 17 and the jakarta.servlet namespace (from javax.servlet). I believe that's mostly the only conflict on this branch.

Ok, the conflict has been resolved.

sjohnr
sjohnr suggested changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terminux, thanks for the PR and rebasing! I think this is really great, and already coming along nicely! I do have some suggestions inline below. I will be out tomorrow, so apologies if you get to this quickly and I'm delayed in reviewing it.

@terminux
Copy link
Contributor Author

Thanks very much for your review @sjohnr . I've updated the PR.

@terminux terminux force-pushed the gh-7765 branch 3 times, most recently from e594f17 to 514bfcf Compare November 22, 2021 02:56
sjohnr
sjohnr suggested changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @terminux! I just have a few more suggestions below.

@terminux
Copy link
Contributor Author

Thanks @sjohnr , nice suggestions. I updated the PR and it's ready for your review again.

sjohnr
sjohnr reviewed Nov 23, 2021
View reviewed changes
Copy link
Contributor

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more suggestions, in addition to our discussion above. Thanks for your efforts so far, @terminux!

@terminux
Copy link
Contributor Author

Thanks @sjohnr , I've updated the PR based on your suggestions.

@sjohnr sjohnr added in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 29, 2021
@sjohnr sjohnr changed the title Support specify IP whitelist for Spring Security Webflux Support IP whitelist for Spring Security Webflux Nov 30, 2021
sjohnr pushed a commit that referenced this pull request Nov 30, 2021
Polish gh-10007
898ba67
@sjohnr sjohnr added this to the 6.0.0-M1 milestone Nov 30, 2021
@sjohnr
Copy link
Contributor

sjohnr commented Nov 30, 2021

Thanks @terminux, this is now in main as 9f51240.

@sjohnr sjohnr closed this Nov 30, 2021
sjohnr pushed a commit that referenced this pull request Nov 30, 2021
Polish gh-10007
204f0b4
@sjohnr sjohnr modified the milestones: 6.0.0-M1, 5.7.0-M1 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjohnr sjohnr sjohnr approved these changes

Assignees

@sjohnr sjohnr

Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.7.0-M1
Development

Successfully merging this pull request may close these issues.

Spring Security WebFlux IP Whitelist
4 participants
@terminux @pivotal-cla @sjohnr @spring-projects-issues