Avoid using SpEL to change the meaning of the injection point #10075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the use of SpEL expression and replaces it with an explicit call to the underlying method.
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the PR @snicoll This is merged into 5.7.0-M1 |
rwinch
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was working with Native, I've noticed that the injection point metadata is changed by a SpEL expression that I found confusing. If the
@Valuedoes not apply, the regular behaviour of framework is to inject all bean of that types it knows about.This commit removes the use of SpEL expression and replaces it with an explicit call to the underlying method. This has the effect of not exposing an additional bean. Additionally, we could move that logic in the configuration class itself.