Add configurable authorities split regex #12073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the PR, @PatrickWalter214! Since this is a new feature, it needs to go into the next minor release, which is 6.1. Will you please:
|
jzheaux
added
type: enhancement
Before this commit splitting the authorities claim was done by a hardcoded regex " ". This commit allows to configure to set any regex to split the authorities claim while keeping the previously hardcoded regex as a default.
PatrickWalter214
force-pushed
the
add-configurable-authorities-split-regex
branch
from
e698cd0 to
64d8ed1
Compare
|
Thank you for reviewing my PR @jzheaux! I performed the steps you mentioned with my latest commit. |
|
Thanks, @PatrickWalter214! This is now merged into |
|
Oops, @PatrickWalter214, my muscle memory got the best of me. 😅 This is not mergeable until after the 6.0 release. I've created a new PR with your commit and will merge it after 6.0 releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to split the authorities claim on a configurable regex, which was previously set ot a hardcoded regex " ". The IAM solution I used provided the authorities separated by another character than ' ' and I realized that with the JwtGrantedAuthoritiesConverter I was not able to set a custom regex. The solution in this PR makes the JwtGrantedAuthoritiesConverter more flexible by supporting this use case while keeping the previous default behaviour.
I signed the individual CLA to provide this PR.