Skip to content

#16889: Remove deprecated cookie comment and version methods #17006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

M-Faheem-Khan
Copy link

ISSUE: gh-16889

Removing deprecated cookie methods comment & version.

These changes partly addresses the gh-16889. To prevent review fatigue, I'll create to additional PRs.

Note: CookieMixinTests will need to be updated when the comment & version methods are removed from the Jakarta Servlet API. PR to deprecate the methods.

@M-Faheem-Khan M-Faheem-Khan changed the title [gh-16889] Remove deprecated cookie comment and version methods #16889: Remove deprecated cookie comment and version methods Apr 28, 2025
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 28, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Apr 29, 2025

Hi, @M-Faheem-Khan, thanks for contributing. There appear to be several changes unrelated to the title in your PR. Can you please rebase with main and update your PR so that it only has your changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants