Use cached requestedSession info if available #1578
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Prevent fetching the session multiple times when checking whether the sessionId has to be sent to the client, by comparing values before clearing the requestedSessionCache. Resolves: spring-projects#1424
oxc
force-pushed
the
use_cached_requested_session
branch
from
b4dbf2d to
66c3984
Compare
|
Apologies for the failed tests. Why is the findById invocation after session commit expected, or rather, what purpose does it serve? Am I missing something here? |
oxc
commented
Mar 3, 2020
| clearRequestedSessionCache(); | ||
| SessionRepositoryFilter.this.sessionRepository.save(session); | ||
| String sessionId = session.getId(); |
There was a problem hiding this comment.
Is the sessionId allowed to change on save? In that case, the comparison should still be done after save, but requestedSessionId has to be retrieved before the clearRequestedSessionCache()
|
This PR should be superseded by #2194 |
|
This has been open for over 3 years. Feel free to reopen if anybody really thinks this is going to get merged somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent fetching the session multiple times when checking whether the
sessionId has to be sent to the client, by comparing values before
clearing the requestedSessionCache.
Resolves: #1424