Fix bug in JDBC SaveMode.ON_GET_ATTRIBUTE
#2040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@felixscheinost Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@felixscheinost Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
eleftherias
added
in: jdbc
type: bug
eleftherias
suggested changes
Mar 10, 2022
There was a problem hiding this comment.
Thanks for the PR @felixscheinost!
I've left a comment below.
Please run ./gradlew format once you've added the changes and squash the commits into a single one.
...n-test/java/org/springframework/session/jdbc/AbstractJdbcIndexedSessionRepositoryITests.java
Outdated
Show resolved
Hide resolved
felixscheinost
force-pushed
the
fix-jdbc-SaveMode-ON_GET_ATTRIBUTE-bug
branch
from
2a43b81 to
8668164
Compare
felixscheinost
force-pushed
the
fix-jdbc-SaveMode-ON_GET_ATTRIBUTE-bug
branch
from
8668164 to
3eaa127
Compare
eleftherias
pushed a commit
that referenced
this pull request
Apr 8, 2022
|
Thanks for the PR @felixscheinost! |
This was referenced Apr 8, 2022
eleftherias
added
the
status: backported
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the
JDBCimplementation ofSaveMode.ON_GET_ATTRIBUTE.I included a testcase that triggers the bug.
The steps to reproduce the bug are:
SaveMode.ON_GET_ATTRIBUTEsetAttributeof a new attributesave, do agetAttributeof the same attributeON_GET_ATTRIBUTEcauses this attribute to be set toDeltaValue.UPDATEDUPDATEDiff not already set toADDEDsavetries to justUPDATEthe new value which fails silently