Skip to content

Align MongoDB session repositories with other implementations #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2022
Merged

Align MongoDB session repositories with other implementations #2173

merged 3 commits into from
Oct 18, 2022

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Oct 5, 2022 •
edited
Loading

This aligns MongoDB session repositories with other implementations by:

  • removing custom Assert utility in favor of standard Spring's equivalents
  • making MongoSessionUtils package private
  • making MongoSession package private

This closes #2170.

@vpavic vpavic changed the title Align MongoDB session repositories with other implementation Align MongoDB session repositories with other implementations Oct 5, 2022
@vpavic vpavic force-pushed the gh-2170 branch 2 times, most recently from ebabd16 to 58b7b7e Compare October 12, 2022 22:03
@vpavic vpavic marked this pull request as ready for review October 14, 2022 17:01
@vpavic
Copy link
Contributor Author

vpavic commented Oct 14, 2022 •
edited
Loading

@rwinch I doubt I'll have time for further alignments (mentioned in #2170) before next week's RC1, but either way these here are the most important ones as they reduce the public API surface. Things like #1993 and #1994 as well as further refinements can easily be done over the course of 3.x lifecycle.

vpavic added 3 commits October 18, 2022 07:21
@vpavic
Use standard Spring utils in MongoDB module
23e3691 
This commit replaces usages of custom assert utility class with standard one from Spring Framework, and removes the custom utility.

See spring-projectsgh-2170
@vpavic
Make MongoSessionUtils package private
3c636da 
See spring-projectsgh-2170
@vpavic
Make MongoSession package private
dcc4906 
See spring-projectsgh-2170
@rwinch rwinch self-assigned this Oct 18, 2022
@rwinch rwinch added type: enhancement A general enhancement in: mongo-db type: breaks-passivity This issue breaks passivity labels Oct 18, 2022
@rwinch rwinch added this to the 3.0.0-RC1 milestone Oct 18, 2022
@rwinch rwinch merged commit bcbe53c into spring-projects:main Oct 18, 2022
@vpavic vpavic deleted the gh-2170 branch October 18, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwinch rwinch

Labels
in: mongo-db type: breaks-passivity This issue breaks passivity type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.0-RC1
Development

Successfully merging this pull request may close these issues.

Align MongoDB session repositories with other implementations
2 participants
@vpavic @rwinch