Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

NewCommitPreorderIter Fails with object not found When iterating over incomplete history. #1151

Open
kwngo/fork.lib.go.go-git
#1
@NonLogicalDev

Description

@NonLogicalDev

In remote.go in getHaves, getHavesRef fails with object not found error when
iterating over incomplete history.

This causes Fetch to fail under certain circumstances, such as (at least) when fetching remotes with unrelated histories.

This likely happens because commits are processed in Preorder and once it reaches the last commit fetched with a given Depth, it fails for find its parent.

Suggestion Short Term

Ignore object not found error during a fetch operation

Suggestion Long Term

Add a terminal empty commit after fetch with a certain depth, to signify that no further commits can be reached. This will guarantee that object not found error if it happens, happens because of corrupt data as opposed to truncated history.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions