ResolveRevision doesn't resolve ambigious revs

[ZJvandeWeg]

When a branch has the same name as the SHA of the commit it depends on, ResolveRevision() doesn't correctly resolve it.

I'm not sure how users get in this situation, but to reproduce:

$ git init
$ touch file && git add . && git commit -m "init commit"
$ git checkout -b $(git rev-parse HEAD)

[ZJvandeWeg]

Seems like it should be supported through #706, I'll take another look later this week.

[mcuadros]

@antham can you please take a look?

[antham]

yes

[antham]

In this case you get a warning like this when you do a rev-parse

warning: refname 'c75323d86168af6202ec4b314b249c78a62b0a8c' is ambiguous.
Git normally never creates a ref that ends with 40 hex characters
because it will be ignored when you just specify 40-hex. These refs
may be created by mistake. For example,

  git checkout -b $br $(git rev-parse ...)

where "$br" is somehow empty and a 40-hex ref is created. Please
examine these refs and maybe delete them. Turn this message off by
running "git config advice.objectNameWarning false"

so what I've done in this case is to return an error.

[antham]

@mcuadros

[antham]

@mcuadros ?