This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Drop indexes in progress. #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kuba-- <[email protected]>
kuba--
added
enhancement
erizocosmico
reviewed
Sep 7, 2018
| } | ||
|
|
||
| return idx | ||
| return r.indexes[indexKey{db, strings.ToLower(id)}] |
There was a problem hiding this comment.
if we remove this, can't queries use indexes while it's still being created?
There was a problem hiding this comment.
Should be fine. I've double checked it. For regular queries we use IndexByExpression function where we still have the check:
if !r.canUseIndex(idx) {
continue
}
erizocosmico
approved these changes
Sep 7, 2018
Signed-off-by: kuba-- <[email protected]>
|
we are not testing deletion of index with several expressions: https://codecov.io/gh/src-d/go-mysql-server/compare/ad0eefd9bc595f6768de9f49c03f44e0c0f0e2e7...4e50b69e441c054a50523e475cd0fbf777046c51/src/sql/index/pilosa/driver.go#L372 can you check that? |
added 2 commits
September 7, 2018 16:21
Signed-off-by: kuba-- <[email protected]>
Signed-off-by: kuba-- <[email protected]>
|
@ajnavarro - I've added |
ajnavarro
approved these changes
Sep 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- [email protected]
Closes #343
Changes:
Right now we can drop/cancel indexes in progress.
Function
IndexesByTablereturns all indexes (NotReadyas well), so if you want to know status you have to callCanUseIndex.Delete index uses
forceflag (what cancel the context what breaks and deletes the index).SHOW INDEX FROM...shows all indexes, butNotReadyindexes have NO in columnVisible, otherwise YES.