Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

sql: add timing info to span traces #470

Merged
merged 1 commit into from
Oct 18, 2018
Merged

sql: add timing info to span traces #470

merged 1 commit into from
Oct 18, 2018

Conversation

erizocosmico
Copy link
Contributor

Closes #466

@erizocosmico erizocosmico requested a review from a team October 18, 2018 08:20
kuba--
kuba-- reviewed Oct 18, 2018
View reviewed changes
sql/session.go Outdated
log.String("total_time", i.total.String()),
log.String("max_time", i.max.String()),
log.String("min_time", i.min.String()),
log.String("avg_time", (i.total / time.Duration(i.count)).String()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible here to have div by 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, you're right

jfontan
jfontan approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@jfontan jfontan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from the division by 0 pointed by @kuba-- LGTM.

@erizocosmico
Copy link
Contributor Author

Just fixed the div by 0 thing

@ajnavarro ajnavarro merged commit 5077ae6 into src-d:master Oct 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jfontan jfontan jfontan approved these changes

@ajnavarro ajnavarro ajnavarro approved these changes

@kuba-- kuba-- kuba-- approved these changes

@mcarmonaa mcarmonaa mcarmonaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erizocosmico @jfontan @ajnavarro @kuba-- @mcarmonaa