This repository was archived by the owner on Jan 28, 2021. It is now read-only.
sql: function, added soundex #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bake <[email protected]>
Signed-off-by: bake <[email protected]>
kuba--
reviewed
Oct 22, 2018
| if b.Len() == 0 { | ||
| return "", nil | ||
| } | ||
| for i := len([]rune(b.String())); i < 4; i++ { |
There was a problem hiding this comment.
why 4 (because type rune = int32)?
There was a problem hiding this comment.
Even though the reference doesn't say so, MySQL returns at least four characters, if one of them is a letter:
mysql> select soundex('');
+-------------+
| soundex('') |
+-------------+
| |
+-------------+
1 row in set (0,00 sec)
mysql> select soundex('Q');
+--------------+
| soundex('Q') |
+--------------+
| Q000 |
+--------------+
1 row in set (0,00 sec)
mysql> select soundex('Quadratically');
+--------------------------+
| soundex('Quadratically') |
+--------------------------+
| Q36324 |
+--------------------------+
1 row in set (0,00 sec)
There was a problem hiding this comment.
I am not sure how close this should follow MySQL, since it is not a replacement. Always returning a string of 0 or 4 characters would be a possibility, too.
|
@kuba-- Should I change something? |
kuba--
approved these changes
Oct 26, 2018
|
@bakerolls - could you rebase. Btw. I accepted this PR but to merge it we have to wait for a maintainer. |
ajnavarro
approved these changes
Oct 26, 2018
Signed-off-by: bake <[email protected]> # Conflicts: # sql/expression/function/registry.go
jfontan
approved these changes
Oct 26, 2018
|
Thank you! |
|
@bakerolls thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a soundex function as described in the MySQL Reference and implemented in mf_soundex.c in mysql/mysql-server.