Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

Upgrade vitess to v1.2.1 #512

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Upgrade vitess to v1.2.1 #512

merged 2 commits into from
Oct 31, 2018

Conversation

kuba--
Copy link
Contributor

@kuba-- kuba-- commented Oct 28, 2018

Signed-off-by: kuba-- [email protected]

@kuba-- kuba-- requested a review from ajnavarro October 28, 2018 12:34
@kuba--
Copy link
Contributor Author

kuba-- commented Oct 28, 2018

After upgrading vitess (and tag it v.1.2.1) I've just run:
GO111MODULE=ON go build ./...

@erizocosmico
Copy link
Contributor

CI is failing

@kuba--
Copy link
Contributor Author

kuba-- commented Oct 30, 2018

I'm off, but something with logging on vitess has been changed. I'll investigate tonight.

@erizocosmico
Copy link
Contributor

Don't worry, there's no hurry with this. Enjoy the day off!

@kuba--
Copy link
Contributor Author

kuba-- commented Oct 30, 2018

It's panics because we replaced glog by logrus.
glog in init function defines flags:
flag.Var(&logging.stderrThreshold, "stderrthreshold", "logs at or above this threshold go to stderr")

If we replaced glog by logrus then stderrthreshold is not defined, but is required by logutil package (logutil/level.go):

func init() {
	threshold := flag.Lookup("stderrthreshold")
	if threshold == nil {
		panic("the logging module doesn't specify a stderrthreshold flag")
	}
//...

@kuba-- kuba-- added wip work in progress enhancement New feature or request and removed enhancement New feature or request labels Oct 31, 2018
@kuba-- kuba-- removed the wip work in progress label Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants