This repository was archived by the owner on Jan 28, 2021. It is now read-only.
auth: add Audit to log user interactions #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audit is an auth.Auth wrapper that does audit trail calls to log user
interaction. An AuditMethod implements functions that are called when
authentication, authorization or query is used.
userAuth, _ := auth.NewNativeFile(userFile)
audit := auth.NewAuditLog(logrus.New())
userAuth = auth.NewAudit(userAuth, audit)
Audit can be wrapped by another Audit chaining several AuditMethod. Here
only AuditLog, that sends the data to logrus, is implemented.
Some changes had to be done to previous auth version and context:
* sql.Context now holds the current query
* Auth.Allowed now takes sql.Context as argument
Note: Query is still not used in this code.
Signed-off-by: Javi Fontan <[email protected]>
This makes it more controllable and uses auth from engine. Previously it had to be added to the rules with the builder. Signed-off-by: Javi Fontan <[email protected]>
This new call logs queries even when they have an error and show how much time they took. Signed-off-by: Javi Fontan <[email protected]>
Signed-off-by: Javi Fontan <[email protected]>
ajnavarro
approved these changes
Nov 6, 2018
mcarmonaa
reviewed
Nov 6, 2018
auth/audit.go
Outdated
| } | ||
| } | ||
|
|
||
| var auditLogMessage = "audit trail" |
Signed-off-by: Javi Fontan <[email protected]>
erizocosmico
approved these changes
Nov 6, 2018
mcarmonaa
approved these changes
Nov 7, 2018
kuba--
approved these changes
Nov 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditis anauth.Authwrapper that does audit trail calls to log userinteraction. An
AuditMethodimplements functions that are called whenauthentication, authorization or query is used.
Auditcan be wrapped by anotherAuditchaining severalAuditMethod. Hereonly
AuditLog, that sends the data tologrus, is implemented.Some changes had to be done to previous auth version and context:
sql.Contextnow holds the current queryAuth.Allowednow takessql.Contextas argumentAuthis anAudititsQuerymethod is called by engineFixes: #496