This repository was archived by the owner on Jan 28, 2021. It is now read-only.
sql: add Databaser interface for cleaner analyzer rules #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Molina <[email protected]>
kuba--
approved these changes
Jan 17, 2019
mcarmonaa
approved these changes
Jan 17, 2019
ajnavarro
approved these changes
Jan 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the messy and very repeated code we had on the
resolve_databaserule, as @kuba-- pointed out in another PR.Introduces a new interface
Databaser, which is a node that contains a ref to a database and now all of the nodes that were changed in theresolve_databaserule can just implement this method and handle all of them the exact same way.