Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

sql: better errors for invalid argument number #596

Merged
merged 1 commit into from
Jan 28, 2019
Merged

sql: better errors for invalid argument number #596

merged 1 commit into from
Jan 28, 2019

Conversation

erizocosmico
Copy link
Contributor

Fixes #591

@erizocosmico erizocosmico requested a review from a team January 18, 2019 13:52
kuba--
kuba-- approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@kuba-- kuba-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for all these case we can use String function (if it's possible).

@ajnavarro
Copy link
Contributor

@kuba-- you cannot use the String method before having the instance on the constructor, right?

@ajnavarro ajnavarro merged commit 528cdba into src-d:master Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jfontan jfontan jfontan approved these changes

@ajnavarro ajnavarro ajnavarro approved these changes

@kuba-- kuba-- kuba-- approved these changes

@mcarmonaa mcarmonaa mcarmonaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erizocosmico @ajnavarro @jfontan @kuba-- @mcarmonaa