Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

Update readme #624

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Update readme #624

merged 2 commits into from
Feb 27, 2019

Conversation

kuba--
Copy link
Contributor

@kuba-- kuba-- commented Feb 25, 2019

Signed-off-by: kuba-- [email protected]
Closes #622

@kuba-- kuba-- added the documentation This is a documentation issue or pull request label Feb 25, 2019
@kuba-- kuba-- requested a review from a team February 25, 2019 15:20
Copy link
Contributor

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after removing changes on go.sum

Signed-off-by: kuba-- <[email protected]>
@kuba--
Copy link
Contributor Author

kuba-- commented Feb 27, 2019

@ajnavarro done

@ajnavarro
Copy link
Contributor

@kuba-- Travis is failing, is this PR rebased with master?

Signed-off-by: kuba-- <[email protected]>
@kuba--
Copy link
Contributor Author

kuba-- commented Feb 27, 2019

@ajnavarro, yes it was rebased. I just reverted go.mod file.
Anyway, I think it's ok to commit go mod tidy artifacts.
The problem is rubex package. It cannot be downloaded just like that (you have to specify which one) because we rely only on go1 branch.
Builds for integration tests failed because we use there go1.11 modules.

@kuba--
Copy link
Contributor Author

kuba-- commented Feb 27, 2019

@ajnavarro now tests pass, but I had to commit again go.mod files

@ajnavarro ajnavarro merged commit a50a0d2 into src-d:master Feb 27, 2019
@kuba-- kuba-- deleted the fix-622 branch February 27, 2019 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation This is a documentation issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants