App engine #122
Merged
App engine #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @miccehedin 👍 I'll get it merged soon. It just needs some test fixing and some extra tests for the AppEngine functionality and then it's good to go! |
src/CloudTasksServiceProvider.php
Outdated
| $this->app->singleton(CloudTasksClient::class, function ($app) { | ||
| $config = config('queue.connections.cloudtasks'); | ||
| $options = []; | ||
| if (!empty($config['credential_file'])) { |
There was a problem hiding this comment.
@miccehedin This can already be done by setting the GOOGLE_APPLICATION_CREDENTIALS environment. Can I therefore remove this bit?
marickvantuil
added
the
safe-to-test
github-actions
bot
removed
the
safe-to-test
marickvantuil
added
the
safe-to-test
github-actions
bot
removed
the
safe-to-test
marickvantuil
added
the
safe-to-test
marickvantuil
force-pushed
the
app-engine
branch
from
4e7aad0 to
74c96ad
Compare
|
Thnx @miccehedin, I just tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add two things:
1: Use a local credential file for authenticating task submisson (useful for local testing).
2: Option to us App Engine task instead of Http task. This makes the process take place in app engine only, and e.g. the app engine service to handle the task can be specified.