Fix - Parameterize config to accept connection names. #23
Conversation
- `TaskHandler` still needs to be updated. Might look for some input there.
- This attempts to obtain the connection name as early as possible so that it can be passed as needed. - We'll continue to default to `"cloudtasks"`
src/TaskHandler.php
Outdated
| $command = unserialize($task['data']['command']); | ||
| $connection = $command->connection ?? 'cloudtasks'; |
There was a problem hiding this comment.
I had to flip the order here a little. The payload is being unserialized and read for the connection value as it cannot be authorized without knowing which connection to use! 😄
|
Thanks for this fix! I've fixed one test that was failing. Locally something was still breaking for me. When I push to the default queue that has a different connection name than cloudtasks, and then later get the connection name from the payload, it seemed to be null (think thats default Laravel behavior?):
Fixed that by using the default connection name in that case, instead of cloudtasks. Also did a pass to clean up the config, what do you think? |
|
It might depend on the connection being explicitly specified on the job itself, which is a property that laravel defines that jobs can set/override. But yeah, looks good! I can try this out right away once it's merged and the package is updated. 😁 |
Closes: #22
@marickvantuil - The one thing I could use your input on is how to update the calls to
ConfiginTaskHandler. I've made a first attempt at it and tested it locally with a payload and it checks out!