Re-use mapConsumer when resolving multiple call stacks

[mattzeunert]

Every time pinpoint is called a new SourceMap.SourceMapConsumer object is created. Loading the source map into the consumer object is slow, so for multiple pinpoint calls the mapConsumer should be re-used.

Possible Solution

This change could be made without any changes to the API. However, caching the mapConsumer uses a lot of memory, so maybe this behavior should be opt-in only.

Maybe a cacheMapConsumers boolean could be passed into the StacktraceGPS constructor?

I can submit a PR if we can agree on an API.

[abhinavsinghvi]

I was also facing similar problem, I have added #43. Let me know what do you think..

[eriwen]

This is partially fixed by e173aff — we can take it a step further by splitting up _extractLocationInfoFromSourceMapSource and caching the Promise. This will prevent creating multiple SourceMapConsumers when getting mapped location from the same source file (if multiple StackFrames reference the same source file).

I'm afraid I don't have time for this refactoring tonight. Hopefully will find time soon.

[eriwen]

@mattzeunert @abhinavsinghvi I created a candidate fix that caches SourceMapConsumer Promises, but as you can see it fails in a couple edge cases on Travis CI. I'm sure I missed something silly, but I'll have to attack this another day. It would be extra cool if one of you can figure out what I missed. Just run gulp test-pr to test in real browsers locally.

[mattzeunert]

I've reproduced and fixed the issue locally, and the PR is passing. But I think the PR tests are only a subset of the full tests from the push you referenced, so there might still be issues.

[eriwen]

This is fixed, as verified by tests, by merging #48. Thanks again both; this will ship in v3.0.0 soon!

[abhinavsinghvi]

What is the plan for releasing stacktrace js with these changes? Thanks.

[eriwen]

I'm hoping to prioritize some time on stacktrace.js in the next couple weeks.

…

On Thu, Jan 12, 2017 at 4:29 AM Abhinav Singhvi ***@***.***> wrote: What is the plan for releasing stacktrace js with these changes? Thanks. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#41 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADJTuaA6p2pGZsEECD_UGqUe9B-fgxdks5rRg6UgaJpZM4KbIM2> .

[abhinavsinghvi]

Hi Eriwen, Please let me know if you are planning to release stacktrace js library with these changes anytime soon. Thanks,