Add error message to report #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 19, 2016 09:56
| * | ||
| * @param {Array} stackframes | ||
| * @param {String} url | ||
| */ | ||
| report: function StackTrace$$report(stackframes, url) { | ||
| report: function StackTrace$$report(errorMsg, stackframes, url) { |
There was a problem hiding this comment.
Putting the error message first breaks the API, I'm afraid.
There was a problem hiding this comment.
Are you suggesting to move it to last? Or is creating a completely separate method better?
There was a problem hiding this comment.
Moving the argument would be sufficient. We may also only want to assign the message if it's populated.
eriwen
added a commit
that referenced
this pull request
May 28, 2016
|
Thank you @rhart - This has been published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new field,
message, to the report function.Motivation and Context
Reporting the stackframes without the actual error message means you don't get the full context of the problem on the server you're reporting to.
How Has This Been Tested?
Existing test has been modified.
Types of changes
Checklist:
node_modules/.bin/jscs -c .jscsrc stacktrace.jspasses without errorsnpm testpasses without errors