Skip to content

feat: add C implementation for math/base/special/max #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Mar 10, 2024
Merged

feat: add C implementation for math/base/special/max #1459

merged 30 commits into from
Mar 10, 2024

Conversation

Shashankss1205
Copy link
Contributor

@Shashankss1205 Shashankss1205 commented Mar 2, 2024 •
edited
Loading

Resolves #1433 .

Description

This pull request adds native C implementation for
@stdlib/math/base/special/max for issue #1433 .

What is the purpose of this pull request?
Native C implementation of max function
This pull request:

  • a
  • b
  • c

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #
  • fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Shashankss1205 Shashankss1205 mentioned this pull request Mar 2, 2024
Closed
3 tasks
Pranavchiku
Pranavchiku suggested changes Mar 3, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes, once done this PR can be reviewed again.

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Mar 3, 2024
Pranavchiku
Pranavchiku reviewed Mar 3, 2024
View reviewed changes
Pranavchiku
Pranavchiku suggested changes Mar 3, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more changes and this be good to merge.

@Pranavchiku Pranavchiku changed the title feat: Add C implementation for @stdlib/math/base/special/max feat: Add C implementation for @stdlib/math/base/special/max Mar 3, 2024
@Shashankss1205
Update README.md
ec098db 
Signed-off-by: Shashank Shekhar Singh <[email protected]>
@Shashankss1205
Update Makefile
082e63c 
Signed-off-by: Shashank Shekhar Singh <[email protected]>
@Shashankss1205
Rename addone.c to addon.c
7eea6e5 
Signed-off-by: Shashank Shekhar Singh <[email protected]>
@Shashankss1205
Update main.c
29c24e6 
Signed-off-by: Shashank Shekhar Singh <[email protected]>
@Planeshifter Planeshifter changed the title feat: Add C implementation for @stdlib/math/base/special/max feat: dd C implementation for math/base/special/max Mar 3, 2024
@Planeshifter Planeshifter changed the title feat: dd C implementation for math/base/special/max feat: Add C implementation for math/base/special/max Mar 3, 2024
@Planeshifter Planeshifter changed the title feat: Add C implementation for math/base/special/max feat: add C implementation for math/base/special/max Mar 3, 2024
@Shashankss1205
Copy link
Contributor Author

please close the PR if the issue has been resolved @Pranavchiku .

@kgryte kgryte mentioned this pull request Mar 4, 2024
Merged
1 task
Pranavchiku
Pranavchiku suggested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, minor changes and this will be ready.

@Shashankss1205
Copy link
Contributor Author

Please take a look at this once @Pranavchiku . Sorry for the extraneous commits, I will try to keep them clean from the next PR's

@Shashankss1205
Copy link
Contributor Author

Please take a look at this once @Pranavchiku @Planeshifter.

Sorry for the extraneous commits, I will try to keep them clean from the next PR's I am just a beginner in open source.

Planeshifter
Planeshifter reviewed Mar 10, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 10, 2024
View reviewed changes
Planeshifter
Planeshifter approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge once CI checks have cleared.

Thank you!

@Planeshifter Planeshifter merged commit 6831521 into stdlib-js:develop Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku requested changes

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/max
3 participants
@Shashankss1205 @Planeshifter @Pranavchiku