Skip to content

refactor: use external constant and update license in math/base/special/pow #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Nov 9, 2024

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Nov 9, 2024
Signed-off-by: Gunj Joshi <[email protected]>
@gunjjoshi gunjjoshi changed the title refactor: use external constant in math/base/special/pow refactor: use external constant and update license in math/base/special/pow Nov 9, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! PR looks fine. Noticing that linting fails due to different parameter names for pow between the C source and header files. Would you be able to rectify that as part of this PR?

Signed-off-by: Gunj Joshi <[email protected]>
@gunjjoshi
Copy link
Member Author

Thanks! PR looks fine. Noticing that linting fails due to different parameter names for pow between the C source and header files. Would you be able to rectify that as part of this PR?

Made the changes, @Planeshifter. Thanks for the suggestions!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Nov 10, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

refactor: use external constant and update license in `math/base/special/pow`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3082

Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit e093a4d into stdlib-js:develop Nov 10, 2024
14 of 15 checks passed
aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
…ial/pow`

PR-URL: stdlib-js#3082

Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants