Skip to content

test: add tests to blas/ext/base/dnannsumkbn #3218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2024
Merged

test: add tests to blas/ext/base/dnannsumkbn #3218

merged 2 commits into from
Nov 21, 2024

Conversation

saurabhraghuvanshii
Copy link
Contributor

@saurabhraghuvanshii saurabhraghuvanshii commented Nov 21, 2024 •
edited
Loading

Resolves #3201.

Description

What is the purpose of this pull request?

This pull request:

  • Adds test case for blas/ext/base/dnannsumkbn

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 21, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 21, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dnannsumkbn $\color{green}428/428$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}428/428$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@saurabhraghuvanshii saurabhraghuvanshii changed the title test: add tests to blas/ext/base/dnannnsumbn test: add tests to blas/ext/base/dnannsumbn Nov 21, 2024
@saurabhraghuvanshii saurabhraghuvanshii changed the title test: add tests to blas/ext/base/dnannsumbn test: add tests to blas/ext/base/dnannsumkbn Nov 21, 2024
@headlessNode
Copy link
Member

@saurabhraghuvanshii The test failure is from a downstream test suite. Not from this PR.

@headlessNode headlessNode added the Tests Pull requests specifically adding tests. label Nov 21, 2024
@saurabhraghuvanshii
Copy link
Contributor Author

@headlessNode so I have to nothing with it

@headlessNode
Copy link
Member

@saurabhraghuvanshii Yes. The PR is looking good.

@kgryte
Copy link
Member

kgryte commented Nov 21, 2024

/stdlib merge

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Nov 21, 2024
@kgryte
Copy link
Member

kgryte commented Nov 21, 2024

/stdlib help

@stdlib-bot
Copy link
Contributor

@kgryte, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Nov 21, 2024
kgryte
kgryte approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @saurabhraghuvanshii!

@kgryte
Copy link
Member

kgryte commented Nov 21, 2024

As the CI failure is due to an expected downstream test failure and will be fixed in a subsequent PR/commit, I'll go ahead and merge.

@kgryte kgryte merged commit 243fe3d into stdlib-js:develop Nov 21, 2024
41 of 43 checks passed
@kgryte kgryte changed the title test: add tests to blas/ext/base/dnannsumkbn test: add tests to blas/ext/base/dnannsumkbn Nov 21, 2024
@saurabhraghuvanshii saurabhraghuvanshii deleted the dnannsumbn-test branch November 22, 2024 07:07
pranav-1720 pushed a commit to pranav-1720/stdlib that referenced this pull request Nov 25, 2024
@saurabhraghuvanshii @pranav-1720
test: add tests to blas/ext/base/dnannsumkbn
398d4ec 
PR-URL: stdlib-js#3218
Closes: stdlib-js#3201
Reviewed-by: Athan Reines <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Dec 4, 2024
@saurabhraghuvanshii @Neerajpathak07
test: add tests to blas/ext/base/dnannsumkbn
9b63d31 
PR-URL: stdlib-js#3218
Closes: stdlib-js#3201
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Tests Pull requests specifically adding tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Incomplete code coverage for blas/ext/base/dnannsumkbn
4 participants
@saurabhraghuvanshii @stdlib-bot @headlessNode @kgryte