Skip to content

feat: add array/base/broadcasted-quinary5d #3229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from

Conversation

RiyaChy072
Copy link

@RiyaChy072 RiyaChy072 commented Nov 23, 2024

Resolves #3172 .

Description

What is the purpose of this pull request?

This pull request:

  • This pull request proposes a new package to the array/base/* namespace: @stdlib/array/base/broadcasted-quinary5d.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@RiyaChy072
Copy link
Author

@kgryte Can you please check if it's done?

@Neerajpathak07
Copy link
Member

@RiyaChy072 use backticks while naming packages.
Ex:- array/base/broadcasted-quinary5d

@Neerajpathak07
Copy link
Member

Also your tests are failing.
Just a point to add try running them locally using :- make TESTS_FILTER="./array/base/broadcasted-quinary5d/." test locally to know the errors. It did help me resolving bugs.

@RiyaChy072
Copy link
Author

@Neerajpathak07 Thanks for the advice

@kgryte kgryte changed the title [RFC]: add array/base/broadcasted-quinary5d feat: add array/base/broadcasted-quinary5d Nov 24, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. Needs Changes Pull request which needs changes before being merged. labels Nov 24, 2024
@kgryte
Copy link
Member

kgryte commented Dec 11, 2024

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 11, 2024
@kgryte kgryte added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Dec 11, 2024
@kgryte
Copy link
Member

kgryte commented Dec 11, 2024

/stdlib help

@stdlib-bot
Copy link
Contributor

@kgryte, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 11, 2024
@kgryte
Copy link
Member

kgryte commented Dec 11, 2024

@RiyaChy072 Thanks for working on this. Looks like this PR needs a bit more attention before we can provide further review. Once CI failures have been resolved, feel free to request another review.

@RiyaChy072
Copy link
Author

@Neerajpathak07 Can you help me a little bit with these please?

@Neerajpathak07
Copy link
Member

Neerajpathak07 commented Dec 14, 2024

@RiyaChy072 Firstly refer this pr:- #3171 as it is the 4d implementation of your current PR.
Your Test.js file is incorrect change var v to var out for every single file where you made that change.
Next your shapes do not match with the values like in this case :-

/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/array/base/broadcasted-quinary5D/lib/main.js:236
            x2 = x3[ j3 ];
                   ^

TypeError: Cannot read properties of undefined (reading '0')

Most of the errors should be resolved once you have fixed the /test file.
You will be having a few lint errors but you can work on that on a separate commit.

@RiyaChy072
Copy link
Author

@Neerajpathak07 Thanks

@Neerajpathak07
Copy link
Member

@RiyaChy072 are you able to solve this issue or you still need some help?

@RiyaChy072
Copy link
Author

@Neerajpathak07 I'm trying to figure things out. I'll let you know if i encounter any issues

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 20, 2024

Coverage Report

Package Statements Branches Functions Lines
array/base/broadcasted-quinary5D $\color{green}364/364$
$\color{green}+100.00\%$
$\color{green}14/14$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}364/364$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@RiyaChy072
Copy link
Author

@Neerajpathak07 CI report has been cleared. Thank you very much for helping me

@RiyaChy072
Copy link
Author

@kgryte CI failures have been resolved. Can you please check?

@Neerajpathak07
Copy link
Member

Neerajpathak07 commented Dec 20, 2024

@RiyaChy072 It seems you have added changes into array/base/broadcasted-binary5d but these are not necessary in this particular PR.
I suggest you to remove the file from the commit. So that we only have code coverage for array/base/broadcasted-quinary5D

@RiyaChy072
Copy link
Author

RiyaChy072 commented Dec 21, 2024

@Neerajpathak07 I did that by mistake

@Neerajpathak07
Copy link
Member

@RiyaChy072 LGTM just resolve the merge conflicts and the pr should be ready.

@RiyaChy072
Copy link
Author

@Neerajpathak07 Did what you said. Now do i need to do anything else?

@RiyaChy072
Copy link
Author

@kgryte Is it done? Can you please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add array/base/broadcasted-quinary5d
4 participants