-
-
Notifications
You must be signed in to change notification settings - Fork 821
feat: add array/base/broadcasted-quinary5d
#3229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
PR-URL: stdlib-js#3117 Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: stdlib-bot <[email protected]>
@kgryte Can you please check if it's done? |
@RiyaChy072 use backticks while naming packages. |
Also your tests are failing. |
@Neerajpathak07 Thanks for the advice |
array/base/broadcasted-quinary5d
Signed-off-by: Athan <[email protected]>
/stdlib lint-autofix |
/stdlib help |
@kgryte, available slash commands include:
|
Signed-off-by: Athan <[email protected]>
@RiyaChy072 Thanks for working on this. Looks like this PR needs a bit more attention before we can provide further review. Once CI failures have been resolved, feel free to request another review. |
@Neerajpathak07 Can you help me a little bit with these please? |
@RiyaChy072 Firstly refer this pr:- #3171 as it is the 4d implementation of your current PR.
Most of the errors should be resolved once you have fixed the |
@Neerajpathak07 Thanks |
@RiyaChy072 are you able to solve this issue or you still need some help? |
@Neerajpathak07 I'm trying to figure things out. I'll let you know if i encounter any issues |
Coverage Report
The above coverage report was generated for the changes in this PR. |
@Neerajpathak07 CI report has been cleared. Thank you very much for helping me |
@kgryte CI failures have been resolved. Can you please check? |
@RiyaChy072 It seems you have added changes into array/base/broadcasted-binary5d but these are not necessary in this particular PR. |
@Neerajpathak07 I did that by mistake |
…mark/benchmark.js Signed-off-by: Riya Chowdhury <[email protected]>
@RiyaChy072 LGTM just resolve the merge conflicts and the pr should be ready. |
@Neerajpathak07 Did what you said. Now do i need to do anything else? |
@kgryte Is it done? Can you please check? |
Resolves #3172 .
Description
This pull request:
Related Issues
This pull request:
array/base/broadcasted-quinary5d
#3172Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers