feat: add C implementation for stats/base/dists/normal/logcdf
#3988
+1,421
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
Statistics
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/stats/base/dists/normal/logcdf/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/normal/logcdf/src/main.c
Outdated
Show resolved
Hide resolved
Planeshifter
changed the title
stats/base/dists/normal/logcdf
|
/stdlib update-copyright-years |
stdlib-bot
added
the
bot: In Progress
stdlib-bot
removed
the
bot: In Progress
| * // returns ~-0.023 | ||
| */ | ||
| double stdlib_base_dists_normal_logcdf( const double x, const double mu, const double sigma ) { | ||
|
|
There was a problem hiding this comment.
Empty line can be removed.
Comment on lines
+33
to
+37
| * @param x input value | ||
| * @param mu mean of the distribution | ||
| * @param sigma standard deviation of the distribution | ||
| * @return evaluated log CDF | ||
| * |
There was a problem hiding this comment.
Parameter descriptions should be aligned.
|
|
||
| #### stdlib_base_dists_normal_logcdf( x, mu, sigma ) | ||
|
|
||
| Evaluates the logarithm of the cumulative distribution function (logCDF) for a normal distribution. |
There was a problem hiding this comment.
Suggested change
| Evaluates the logarithm of the cumulative distribution function (logCDF) for a normal distribution. | |
| Evaluates the natural logarithm of the [cumulative distribution function][cdf] (CDF) for a [normal][normal-distribution] distribution with parameters `mu` (mean) and `sigma` (standard deviation). |
Planeshifter
requested changes
Feb 21, 2025
| #include <time.h> | ||
|
|
||
| static double random_uniform( const double min, const double max ) { | ||
| double v = (double)rand() / ( (double)RAND_MAX + 1.0 ); |
There was a problem hiding this comment.
All C files in this PR should use TAB-indentation.
| #include "stdlib/math/base/special/abs2.h" | ||
| #include "stdlib/constants/float64/ninf.h" | ||
|
|
||
| #define INV_SQRT_TWO 0.7071067811865475 // 1/sqrt(2) |
There was a problem hiding this comment.
Let's use static const double rather than #define for defining constants (offers type safety and scoped visibility of the contsant to the file, preventing any name clashes).
Planeshifter
added
the
bot: Update Copyright Years
stdlib-bot
added
bot: In Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3774
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers