Skip to content

refactor: update stats/base/dnanmeanpn native addon from C++ to C #4110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 27, 2024
Merged

refactor: update stats/base/dnanmeanpn native addon from C++ to C #4110

merged 4 commits into from
Dec 27, 2024

Conversation

Neerajpathak07
Copy link
Member

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • refactors stats/base/dnanmeanpn to use native addons in C instead of C++

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 20, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 20, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dnanmeanpn $\color{green}455/455$
$\color{green}+100.00\%$ 		$\color{green}43/43$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}455/455$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 20, 2024 20:43
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 20, 2024
kgryte
kgryte reviewed Dec 21, 2024
View reviewed changes
lib/node_modules/@stdlib/stats/base/dnanmeanpn/src/addon.c Outdated
* limitations under the License.
*/

#include <node_api.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect include order.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 21, 2024
@kgryte kgryte changed the title refactor: update stats/base/dnanmeanpn to follow latest project conventions refactor: update stats/base/dnanmeanpn native addon from C++ to C Dec 21, 2024
@kgryte
Copy link
Member

kgryte commented Dec 27, 2024

@Neerajpathak07 Mind resolving the comments above so that we can get this one in? Cheers!

@Neerajpathak07
Copy link
Member Author

@kgryte addressed the CI failures!

kgryte
kgryte approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Dec 27, 2024
@kgryte kgryte merged commit dc8291e into stdlib-js:develop Dec 27, 2024
11 checks passed
@Neerajpathak07 Neerajpathak07 deleted the refactor-dnannmeanpn branch December 27, 2024 11:34
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Dec 27, 2024
@Neerajpathak07 @0PrashantYadav0
refactor: update stats/base/dnanmeanpn native addon from C++ to C
d685018 
PR-URL: stdlib-js#4110
Reviewed-by: Athan Reines <[email protected]>

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Dec 27, 2024
@Neerajpathak07 @0PrashantYadav0
refactor: update stats/base/dnanmeanpn native addon from C++ to C
692afcb 
PR-URL: stdlib-js#4110
Reviewed-by: Athan Reines <[email protected]>

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
Neerajpathak07 added a commit to Neerajpathak07/stdlib that referenced this pull request Jan 1, 2025
@Neerajpathak07
refactor: update stats/base/dnanmeanpn native addon from C++ to C
9608279 
PR-URL: stdlib-js#4110
Reviewed-by: Athan Reines <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@Neerajpathak07 @ShabiShett07
refactor: update stats/base/dnanmeanpn native addon from C++ to C
a176bd7 
PR-URL: stdlib-js#4110
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neerajpathak07 @stdlib-bot @kgryte