Skip to content

feat: add C ndarray interface and refactor implementation for stats/base/dnanmeanors #4248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Feb 9, 2025
Merged

feat: add C ndarray interface and refactor implementation for stats/base/dnanmeanors #4248

merged 27 commits into from
Feb 9, 2025

Conversation

Neerajpathak07
Copy link
Member

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dnanmean
  • refactor JavaScript implementation
  • refactor examples, tests, docs and benchmarks in manifest.json

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

gunjjoshi and others added 2 commits December 26, 2024 10:26
@gunjjoshi @Neerajpathak07
refactor: replace built-ins by stdlib packages, update benchmarks in …
c60ec02 
…`math/base/special/trunc`

PR-URL: stdlib-js#3941

Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@Neerajpathak07
feat: ndarray-dnanmeanors
bc629b6
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 26, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 26, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dnanmeanors $\color{green}363/363$
$\color{green}+100.00\%$ 		$\color{green}21/21$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}363/363$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 26, 2024 07:02
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 26, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 31, 2024
@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 18, 2025 12:55
@Neerajpathak07
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 18, 2025 13:23
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 18, 2025
kgryte
kgryte requested changes Feb 3, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an initial round of comments.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. and removed Needs Review A pull request which needs code review. labels Feb 3, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as draft February 3, 2025 09:52
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review February 3, 2025 10:03
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 3, 2025
@Neerajpathak07 Neerajpathak07 requested a review from kgryte February 3, 2025 10:21
@aayush0325
Copy link
Member

@Neerajpathak07 sorry for the confusion from my side, you should use bernoulli( 0.8 ) < 1 in your rand() function in JS benchmarks, i had suggested bernoulli ( 0.8 < 1 ) which is not correct (notice the brackets).

@Neerajpathak07
Copy link
Member Author

@aayush0325 @kgryte Should this be good to go and if there are any changes remaining do let me know!!

aayush0325
aayush0325 approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@aayush0325 aayush0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@aayush0325 aayush0325 removed the Needs Changes Pull request which needs changes before being merged. label Feb 8, 2025
@kgryte
docs: fix example
d17d759 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Feb 9, 2025
@kgryte kgryte merged commit ea4fd1d into stdlib-js:develop Feb 9, 2025
13 checks passed
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
@Neerajpathak07 @kgryte
@stdlib-bot @saurabhraghuvanshii
feat: add C ndarray interface and refactor implementation for `stats/…
6de6c4f 
…base/dnanmeanors`

PR-URL: stdlib-js#4248
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Aayush Khanna <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@Neerajpathak07 @kgryte
@stdlib-bot @ShabiShett07
feat: add C ndarray interface and refactor implementation for `stats/…
37cc237 
…base/dnanmeanors`

PR-URL: stdlib-js#4248
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Aayush Khanna <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@aayush0325 aayush0325 aayush0325 approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Neerajpathak07 @stdlib-bot @aayush0325 @kgryte @gunjjoshi