Skip to content

refactor: update math/base/special/hypot to follow latest project conventions #4765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 17, 2025
Merged

refactor: update math/base/special/hypot to follow latest project conventions #4765

merged 4 commits into from
Jan 17, 2025

Conversation

vivekmaurya001
Copy link
Contributor

Resolves None.

Description

  • refactored main.c to use stdlib api instead of math.h for math/base/special/hypot
  • updated benchmark calculations
  • updated js examples
  • updated test file
  • updated readme

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@vivekmaurya001
refactor: update math/base/special/hypot to follow latest project con…
eae6f96 
…ventions

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@vivekmaurya001 vivekmaurya001 marked this pull request as draft January 15, 2025 16:42
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jan 15, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 15, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/hypot $\color{green}180/180$
$\color{green}+100.00\%$ 		$\color{green}19/19$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}180/180$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@vivekmaurya001 vivekmaurya001 marked this pull request as ready for review January 15, 2025 16:47
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 15, 2025
@vivekmaurya001
Copy link
Contributor Author

vivekmaurya001 commented Jan 15, 2025 •
edited
Loading

@Planeshifter , @gunjjoshi , please give this a review

gunjjoshi
gunjjoshi requested changes Jan 16, 2025
View reviewed changes
@gunjjoshi gunjjoshi added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 16, 2025
@vivekmaurya001
refactor: update math/base/special/hypot to follow latest project con…
3722f99 
…ventions

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@vivekmaurya001
Copy link
Contributor Author

done the changes @gunjjoshi , i will do the same changes in my other related PR's

@gunjjoshi gunjjoshi added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Jan 17, 2025
kgryte
kgryte approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for reviewing, @gunjjoshi!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jan 17, 2025
@kgryte kgryte merged commit 0900838 into stdlib-js:develop Jan 17, 2025
13 checks passed
@vivekmaurya001 vivekmaurya001 deleted the math/base/hypot branch January 17, 2025 20:41
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 18, 2025
@vivekmaurya001 @kgryte @saurabhraghuvanshii
refactor: update math/base/special/hypot to follow latest project c…
2123372 
…onventions

PR-URL: stdlib-js#4765
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Gunj Joshi <[email protected]>
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 19, 2025
@vivekmaurya001 @kgryte @saurabhraghuvanshii
refactor: update math/base/special/hypot to follow latest project c…
2389b68 
…onventions

PR-URL: stdlib-js#4765
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Gunj Joshi <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@vivekmaurya001 @kgryte @Neerajpathak07
refactor: update math/base/special/hypot to follow latest project c…
08139dc 
…onventions

PR-URL: stdlib-js#4765
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Gunj Joshi <[email protected]>
Vinit-Pandit pushed a commit to Vinit-Pandit/stdlibMine that referenced this pull request Feb 4, 2025
@vivekmaurya001 @kgryte @Vinit-Pandit
refactor: update math/base/special/hypot to follow latest project c…
cef6de0 
…onventions

PR-URL: stdlib-js#4765
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Gunj Joshi <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@vivekmaurya001 @kgryte @ShabiShett07
refactor: update math/base/special/hypot to follow latest project c…
b1ca1bc 
…onventions

PR-URL: stdlib-js#4765
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Gunj Joshi <[email protected]>
@vivekmaurya001 vivekmaurya001 mentioned this pull request Mar 26, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@gunjjoshi gunjjoshi gunjjoshi approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivekmaurya001 @stdlib-bot @kgryte @gunjjoshi