Skip to content

refactor: update math/base/special/kernel-tan #5017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

vivekmaurya001
Copy link
Contributor

Resolves None.

Description

  • refactored addon.c to use stdlib api for math/base/special/kernel-tan
  • updated benchmark calculations
  • updated test file

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

…nventions

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Feb 2, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 2, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/kernel-tan $\color{red}394/398$
$\color{green}+99.00\%$
$\color{red}15/17$
$\color{green}+88.24\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}394/398$
$\color{green}+99.00\%$

The above coverage report was generated for the changes in this PR.

@vivekmaurya001
Copy link
Contributor Author

good evening @Planeshifter , @kgryte , please take a look

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the clean-up!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Feb 5, 2025
@kgryte kgryte changed the title refactor: update math/base/special/kernel-tan refactor: update math/base/special/kernel-tan Feb 5, 2025
@kgryte kgryte merged commit 7ce2628 into stdlib-js:develop Feb 5, 2025
12 checks passed
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
PR-URL: stdlib-js#5017
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#5017
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants