Skip to content

Fix: commit comments in quantile module (#5897) #6073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

akash8843
Copy link

Resolves #5897

Description

What is the purpose of this pull request?

This pull request fixes comments related to the quantile module functionality for better code clarity and documentation.

Related Issues

Does this pull request have any related issues?

This pull request:
Resolves #5897

Acknowledgment

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request?
This may include screenshots, references, and/or implementation notes.

No.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 15, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/triangular/quantile $\color{green}356/356$
$\color{green}+100.00\%$
$\color{green}35/35$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}356/356$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@akash8843
Copy link
Author

Hi @stdlib-bot ,
I have submitted a pull request for issue #5897: "Fix commit comments in quantile module". I have made the necessary changes as per the guidelines.

Please review it whenever you get time. Let me know if any modifications are needed.

PR Link: [https://github.com//pull/6073#issue-2922074790]

Thank you! 😊

@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
@akash8843
Copy link
Author

Hi @Planeshifter, I noticed that this issue has been marked as "Potential Duplicate" for multiple PRs,
including mine and another contributor's. Could you please clarify if this issue is still open for contributions
or if it has been resolved elsewhere?
I want to make sure I'm contributing to the right place. Thanks for your guidance! 😊

@kgryte kgryte added Duplicate This issue or pull request already exists. and removed Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue. labels Mar 17, 2025
@kgryte
Copy link
Member

kgryte commented Mar 17, 2025

Thank you for your contribution; however, the changes proposed in this PR were already addressed in #5941. As such, I'll go ahead and close.

@kgryte kgryte closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate This issue or pull request already exists. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 3ee60b4)
4 participants