Skip to content

refactor: update add-on, examples, benchmarks, and docs #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 2, 2023
Merged

refactor: update add-on, examples, benchmarks, and docs #799

merged 16 commits into from
Mar 2, 2023

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Jan 23, 2023 •
edited
Loading

Checklist

  • update readme.md
  • docs
  • src
  • include.gypi
  • manifest.json
  • package.json
  • lib
  • examples
  • benchmark
  • test ( No noticable change )

@kgryte

@Pranavchiku Pranavchiku mentioned this pull request Jan 23, 2023
Closed
18 tasks
@Pranavchiku Pranavchiku added Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). labels Jan 23, 2023
@Pranavchiku
Copy link
Member Author

All tests and benchmarks cleared, this PR can have a review.

@Pranavchiku Pranavchiku marked this pull request as ready for review January 23, 2023 05:17
kgryte
kgryte reviewed Jan 31, 2023
View reviewed changes
kgryte
kgryte reviewed Jan 31, 2023
View reviewed changes
kgryte
kgryte reviewed Jan 31, 2023
View reviewed changes
kgryte
kgryte reviewed Jan 31, 2023
View reviewed changes
kgryte
kgryte requested changes Jan 31, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can swap out a macro for another macro to be explicit concerning intent.

@kgryte
Copy link
Member

kgryte commented Feb 14, 2023

@Pranavchiku Once the macro is swapped out, LMK and I'll take another look.

@Pranavchiku
Copy link
Member Author

@kgryte you can have a final review.

kgryte
kgryte reviewed Mar 1, 2023
View reviewed changes
kgryte
kgryte reviewed Mar 1, 2023
View reviewed changes
kgryte
kgryte reviewed Mar 1, 2023
View reviewed changes
kgryte
kgryte reviewed Mar 1, 2023
View reviewed changes
kgryte
kgryte approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Pranavchiku!

@kgryte kgryte changed the title Refactor @stdlib/blas/base/sdsdot refactor: update add-on, examples, benchmarks, and docs Mar 2, 2023
@kgryte kgryte merged commit c8985f2 into stdlib-js:develop Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranavchiku @kgryte