feat: add support for replacing the substring before the first occurrence of a search string #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…place_before_1
kgryte
added
Feature
kgryte
reviewed
Feb 4, 2023
lib/node_modules/@stdlib/string/base/replace-before/lib/main.js
Outdated
Show resolved
Hide resolved
|
@HarshitaKalani Thanks for working this! LMK if/when you'd like me to review or if you have any questions! :) |
|
@kgryte sure :) |
|
Hey @kgryte, I'm almost done with this issue but I'm not sure about the cli file in bin. Please lmk if any updates need to be made. |
|
@HarshitaKalani About to sign off. I'll try to review within the next day or so. |
Pranavchiku
reviewed
Feb 4, 2023
Pranavchiku
reviewed
Feb 4, 2023
Pranavchiku
reviewed
Feb 4, 2023
lib/node_modules/@stdlib/string/base/replace-before/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Feb 4, 2023
lib/node_modules/@stdlib/string/base/replace-before/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
|
I have not checked logic yet, just fix indentation issues, and make sure tests pass, Welcome to stdlib @HarshitaKalani! |
|
I'll make all the corrections. Thanks @Pranavchiku ^_^ |
kgryte
reviewed
Feb 24, 2023
lib/node_modules/@stdlib/string/base/replace-before/test/test.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Feb 24, 2023
kgryte
reviewed
Feb 24, 2023
kgryte
reviewed
Feb 24, 2023
kgryte
reviewed
Feb 24, 2023
kgryte
reviewed
Feb 24, 2023
lib/node_modules/@stdlib/string/base/replace-before/lib/index.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Feb 24, 2023
lib/node_modules/@stdlib/string/base/replace-before/package.json
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Feb 24, 2023
kgryte
reviewed
Feb 24, 2023
lib/node_modules/@stdlib/string/base/replace-before/package.json
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Feb 24, 2023
lib/node_modules/@stdlib/string/base/replace-before/lib/index.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Feb 24, 2023
kgryte
reviewed
Feb 24, 2023
lib/node_modules/@stdlib/string/base/replace-before/lib/main.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Feb 24, 2023
lib/node_modules/@stdlib/string/base/replace-before/lib/main.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Feb 24, 2023
lib/node_modules/@stdlib/string/base/replace-before/lib/main.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Feb 24, 2023
lib/node_modules/@stdlib/string/base/replace-before/lib/main.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Feb 24, 2023
lib/node_modules/@stdlib/string/base/replace-before/test/test.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Feb 24, 2023
lib/node_modules/@stdlib/string/base/replace-before/test/test.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Feb 24, 2023
lib/node_modules/@stdlib/string/base/replace-before/test/test.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Feb 24, 2023
lib/node_modules/@stdlib/string/base/replace-before/test/test.js
Outdated
Show resolved
Hide resolved
kgryte
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
LGTM. @Planeshifter Would you mind reviewing to ensure we haven't missed anything? I've gotten it to pass CI, but would be good to have another set of eyes.
kgryte
changed the title
@stdlib/string/base/replace-before
|
Looks all good to me. Thanks @HarshitaKalani for your contribution! |
|
This PR has now received two approvals. Will merge. Thanks again, @HarshitaKalani, for your patience and continued efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #811 .
With this PR, I've added the readme.md for replace-before issue
I'll be adding other related files after this
@stdlib-js/reviewers