Skip to content

feat: add support for replacing the substring before the first occurrence of a search string #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Feb 24, 2023

Conversation

HarshitaKalani
Copy link
Contributor

Resolves #811 .

With this PR, I've added the readme.md for replace-before issue
I'll be adding other related files after this

@stdlib-js/reviewers

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. labels Feb 4, 2023
@kgryte kgryte marked this pull request as draft February 4, 2023 09:57
@kgryte
Copy link
Member

kgryte commented Feb 4, 2023

@HarshitaKalani Thanks for working this! LMK if/when you'd like me to review or if you have any questions! :)

@HarshitaKalani
Copy link
Contributor Author

@kgryte sure :)

@HarshitaKalani
Copy link
Contributor Author

Hey @kgryte, I'm almost done with this issue but I'm not sure about the cli file in bin. Please lmk if any updates need to be made.

@kgryte
Copy link
Member

kgryte commented Feb 4, 2023

@HarshitaKalani About to sign off. I'll try to review within the next day or so.

@Pranavchiku
Copy link
Member

I have not checked logic yet, just fix indentation issues, and make sure tests pass, Welcome to stdlib @HarshitaKalani!

@HarshitaKalani
Copy link
Contributor Author

I'll make all the corrections. Thanks @Pranavchiku ^_^

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @Planeshifter Would you mind reviewing to ensure we haven't missed anything? I've gotten it to pass CI, but would be good to have another set of eyes.

@kgryte kgryte changed the title Added implementation for @stdlib/string/base/replace-before feat: add support for replacing the substring before the first occurrence of a search string Feb 24, 2023
@Planeshifter
Copy link
Member

Looks all good to me. Thanks @HarshitaKalani for your contribution!

@kgryte
Copy link
Member

kgryte commented Feb 24, 2023

This PR has now received two approvals. Will merge. Thanks again, @HarshitaKalani, for your patience and continued efforts!

@kgryte kgryte merged commit ae68d17 into stdlib-js:develop Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add @stdlib/string/base/replace-before
4 participants