Added the N-Versions of G0(7,8)1G(8,B)U generic Boards #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 29, 2022 09:41
ABOSTM
suggested changes
May 30, 2022
There was a problem hiding this comment.
@microtronics ,
Thanks for this Pull Request.
1 small comment otherwise LGTM
Co-authored-by: Alexandre Bourdiol <[email protected]>
cparata
pushed a commit
to cparata/Arduino_Core_STM32
that referenced
this pull request
Jan 31, 2023
…uino#1730) Co-authored-by: Frederic Pillon <[email protected]> Co-authored-by: Alexandre Bourdiol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added the N-Versions of G0(7,8)1G(8,B)U generic Boards
Validation
Code formatting
Should be fine. CI reports no errors.
Comments
This has become more commits than intended. Tested on a G071GBUxN-breakout and works fine. The other similar variants are also added and should be OK.
One Question is left:
PA0 is A0 for Arduino and USART4_TX (the default Serial). This breaks the AnalogReadSerial example from Arduino. Is this a known issue on the low pin-count devices or are there resolutions that have been used in similar cases?