fix: proper nullable types for Go code gen #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
auto-merge was automatically disabled
February 27, 2025 17:36
Head branch was pushed to by a user without write access
barrownicholas
changed the title
|
@soedirgo can you re-approve the tests for me? I had to re-factor a broken test. |
Pull Request Test Coverage Report for Build 13670517139Details
💛 - Coveralls |
|
@soedirgo looks like it wants another approval |
soedirgo
approved these changes
Mar 5, 2025
avallete
pushed a commit
that referenced
this pull request
May 13, 2025
* fix: proper nullable types * fix: unused imports * fix: tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug Fix: resolves #897
What is the current behavior?
Nullable types are not de-serializable
What is the new behavior?
Null-pointers allow proper serialization and better mimic proper use-case
Additional context
See #897 for full breakdown