Skip to content

fix: this end is not a function error #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025

Conversation

avallete
Copy link
Member

@avallete avallete commented Apr 8, 2025

What kind of change does this PR introduce?

In some cases, the this.end function call raise a this.end is not a function error.
Use the .bind method instead. And wrap the whole connection ending into a try/catch to ensure that unexpected ending error won't cause issue to the server.

@avallete avallete requested review from a team as code owners April 8, 2025 12:41
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14333974906

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 75.874%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/db.ts 3 5 60.0%
Totals Coverage Status
Change from base Build 14333744901: -0.03%
Covered Lines: 4981
Relevant Lines: 6482

💛 - Coveralls

@avallete avallete merged commit b7e23bd into master Apr 8, 2025
5 checks passed
@avallete avallete deleted the fix/this-end-is-not-a-function-error branch April 8, 2025 15:18
avallete added a commit that referenced this pull request May 13, 2025
…error

fix: this end is not a function error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants