-
-
Notifications
You must be signed in to change notification settings - Fork 182
feat: enable webhooks by default #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sweatybridge
wants to merge
5
commits into
develop
Choose a base branch
from
webhooks
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1fd3dc3
feat: enable webhooks by default
sweatybridge e6c0474
feat: support webhook retries
sweatybridge 4bb977b
chore: remove retry logic
sweatybridge 24afeb1
chore: include pg_net in shared preload libraries
sweatybridge 1685528
chore: update extensions unit test
sweatybridge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ SELECT extensions_are( | |
'pg_graphql', | ||
'pgcrypto', | ||
'pgjwt', | ||
'pg_net', | ||
'uuid-ossp', | ||
'supabase_vault' | ||
] | ||
|
243 changes: 243 additions & 0 deletions
243
migrations/db/migrations/20240822021428_enable_webhooks_by_default.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,243 @@ | ||
-- migrate:up | ||
|
||
-- Create pg_net extension | ||
CREATE EXTENSION IF NOT EXISTS pg_net SCHEMA extensions; | ||
|
||
-- Create supabase_functions schema | ||
CREATE SCHEMA IF NOT EXISTS supabase_functions AUTHORIZATION supabase_admin; | ||
|
||
GRANT USAGE ON SCHEMA supabase_functions TO postgres, anon, authenticated, service_role; | ||
ALTER DEFAULT PRIVILEGES IN SCHEMA supabase_functions GRANT ALL ON TABLES TO postgres, anon, authenticated, service_role; | ||
ALTER DEFAULT PRIVILEGES IN SCHEMA supabase_functions GRANT ALL ON FUNCTIONS TO postgres, anon, authenticated, service_role; | ||
ALTER DEFAULT PRIVILEGES IN SCHEMA supabase_functions GRANT ALL ON SEQUENCES TO postgres, anon, authenticated, service_role; | ||
|
||
-- supabase_functions.migrations definition | ||
CREATE TABLE IF NOT EXISTS supabase_functions.migrations ( | ||
version text PRIMARY KEY, | ||
inserted_at timestamptz NOT NULL DEFAULT NOW() | ||
); | ||
|
||
-- Initial supabase_functions migration | ||
INSERT INTO supabase_functions.migrations (version) VALUES | ||
('initial'), | ||
('20210809183423_update_grants') | ||
ON CONFLICT DO NOTHING; | ||
|
||
-- supabase_functions.hooks definition | ||
CREATE TABLE IF NOT EXISTS supabase_functions.hooks ( | ||
id bigserial PRIMARY KEY, | ||
hook_table_id integer NOT NULL, | ||
hook_name text NOT NULL, | ||
created_at timestamptz NOT NULL DEFAULT NOW(), | ||
request_id bigint | ||
); | ||
CREATE INDEX IF NOT EXISTS supabase_functions_hooks_request_id_idx ON supabase_functions.hooks USING btree (request_id); | ||
CREATE INDEX IF NOT EXISTS supabase_functions_hooks_h_table_id_h_name_idx ON supabase_functions.hooks USING btree (hook_table_id, hook_name); | ||
COMMENT ON TABLE supabase_functions.hooks IS 'Supabase Functions Hooks: Audit trail for triggered hooks.'; | ||
|
||
CREATE OR REPLACE FUNCTION supabase_functions.http_request() | ||
RETURNS trigger | ||
LANGUAGE plpgsql | ||
AS $function$ | ||
DECLARE | ||
request_id bigint; | ||
payload jsonb; | ||
url text := TG_ARGV[0]::text; | ||
method text := TG_ARGV[1]::text; | ||
headers jsonb DEFAULT '{}'::jsonb; | ||
params jsonb DEFAULT '{}'::jsonb; | ||
timeout_ms integer DEFAULT 1000; | ||
BEGIN | ||
IF url IS NULL OR url = 'null' THEN | ||
RAISE EXCEPTION 'url argument is missing'; | ||
END IF; | ||
|
||
IF method IS NULL OR method = 'null' THEN | ||
RAISE EXCEPTION 'method argument is missing'; | ||
END IF; | ||
|
||
IF TG_ARGV[2] IS NULL OR TG_ARGV[2] = 'null' THEN | ||
headers = '{"Content-Type": "application/json"}'::jsonb; | ||
ELSE | ||
headers = TG_ARGV[2]::jsonb; | ||
END IF; | ||
|
||
IF TG_ARGV[3] IS NULL OR TG_ARGV[3] = 'null' THEN | ||
params = '{}'::jsonb; | ||
ELSE | ||
params = TG_ARGV[3]::jsonb; | ||
END IF; | ||
|
||
IF TG_ARGV[4] IS NULL OR TG_ARGV[4] = 'null' THEN | ||
timeout_ms = 1000; | ||
ELSE | ||
timeout_ms = TG_ARGV[4]::integer; | ||
END IF; | ||
|
||
CASE | ||
WHEN method = 'GET' THEN | ||
SELECT http_get INTO request_id FROM net.http_get( | ||
url, | ||
params, | ||
headers, | ||
timeout_ms | ||
); | ||
WHEN method = 'POST' THEN | ||
payload = jsonb_build_object( | ||
'old_record', OLD, | ||
'record', NEW, | ||
'type', TG_OP, | ||
'table', TG_TABLE_NAME, | ||
'schema', TG_TABLE_SCHEMA | ||
); | ||
|
||
SELECT http_post INTO request_id FROM net.http_post( | ||
url, | ||
payload, | ||
params, | ||
headers, | ||
timeout_ms | ||
); | ||
ELSE | ||
RAISE EXCEPTION 'method argument % is invalid', method; | ||
END CASE; | ||
|
||
INSERT INTO supabase_functions.hooks | ||
(hook_table_id, hook_name, request_id) | ||
VALUES | ||
(TG_RELID, TG_NAME, request_id); | ||
|
||
RETURN NEW; | ||
END | ||
$function$; | ||
|
||
-- Supabase super admin | ||
DO | ||
$$ | ||
BEGIN | ||
IF NOT EXISTS ( | ||
SELECT 1 | ||
FROM pg_roles | ||
WHERE rolname = 'supabase_functions_admin' | ||
) | ||
THEN | ||
CREATE USER supabase_functions_admin NOINHERIT CREATEROLE LOGIN NOREPLICATION; | ||
END IF; | ||
END | ||
$$; | ||
|
||
GRANT ALL PRIVILEGES ON SCHEMA supabase_functions TO supabase_functions_admin; | ||
GRANT ALL PRIVILEGES ON ALL TABLES IN SCHEMA supabase_functions TO supabase_functions_admin; | ||
GRANT ALL PRIVILEGES ON ALL SEQUENCES IN SCHEMA supabase_functions TO supabase_functions_admin; | ||
ALTER USER supabase_functions_admin SET search_path = "supabase_functions"; | ||
ALTER table "supabase_functions".migrations OWNER TO supabase_functions_admin; | ||
ALTER table "supabase_functions".hooks OWNER TO supabase_functions_admin; | ||
ALTER function "supabase_functions".http_request() OWNER TO supabase_functions_admin; | ||
GRANT supabase_functions_admin TO postgres; | ||
|
||
-- Remove unused supabase_pg_net_admin role | ||
DO | ||
$$ | ||
BEGIN | ||
IF EXISTS ( | ||
SELECT 1 | ||
FROM pg_roles | ||
WHERE rolname = 'supabase_pg_net_admin' | ||
) | ||
THEN | ||
REASSIGN OWNED BY supabase_pg_net_admin TO supabase_admin; | ||
DROP OWNED BY supabase_pg_net_admin; | ||
DROP ROLE supabase_pg_net_admin; | ||
END IF; | ||
END | ||
$$; | ||
|
||
-- pg_net grants when extension is already enabled | ||
DO | ||
$$ | ||
BEGIN | ||
IF EXISTS ( | ||
SELECT 1 | ||
FROM pg_extension | ||
WHERE extname = 'pg_net' | ||
) | ||
THEN | ||
GRANT USAGE ON SCHEMA net TO supabase_functions_admin, postgres, anon, authenticated, service_role; | ||
|
||
ALTER function net.http_get(url text, params jsonb, headers jsonb, timeout_milliseconds integer) SECURITY DEFINER; | ||
ALTER function net.http_post(url text, body jsonb, params jsonb, headers jsonb, timeout_milliseconds integer) SECURITY DEFINER; | ||
|
||
ALTER function net.http_get(url text, params jsonb, headers jsonb, timeout_milliseconds integer) SET search_path = net; | ||
ALTER function net.http_post(url text, body jsonb, params jsonb, headers jsonb, timeout_milliseconds integer) SET search_path = net; | ||
|
||
REVOKE ALL ON FUNCTION net.http_get(url text, params jsonb, headers jsonb, timeout_milliseconds integer) FROM PUBLIC; | ||
REVOKE ALL ON FUNCTION net.http_post(url text, body jsonb, params jsonb, headers jsonb, timeout_milliseconds integer) FROM PUBLIC; | ||
|
||
GRANT EXECUTE ON FUNCTION net.http_get(url text, params jsonb, headers jsonb, timeout_milliseconds integer) TO supabase_functions_admin, postgres, anon, authenticated, service_role; | ||
GRANT EXECUTE ON FUNCTION net.http_post(url text, body jsonb, params jsonb, headers jsonb, timeout_milliseconds integer) TO supabase_functions_admin, postgres, anon, authenticated, service_role; | ||
END IF; | ||
END | ||
$$; | ||
|
||
-- Event trigger for pg_net | ||
CREATE OR REPLACE FUNCTION extensions.grant_pg_net_access() | ||
RETURNS event_trigger | ||
LANGUAGE plpgsql | ||
AS $$ | ||
BEGIN | ||
IF EXISTS ( | ||
SELECT 1 | ||
FROM pg_event_trigger_ddl_commands() AS ev | ||
JOIN pg_extension AS ext | ||
ON ev.objid = ext.oid | ||
WHERE ext.extname = 'pg_net' | ||
) | ||
THEN | ||
IF NOT EXISTS ( | ||
SELECT 1 | ||
FROM pg_roles | ||
WHERE rolname = 'supabase_functions_admin' | ||
) | ||
THEN | ||
CREATE USER supabase_functions_admin NOINHERIT CREATEROLE LOGIN NOREPLICATION; | ||
END IF; | ||
|
||
GRANT USAGE ON SCHEMA net TO supabase_functions_admin, postgres, anon, authenticated, service_role; | ||
|
||
ALTER function net.http_get(url text, params jsonb, headers jsonb, timeout_milliseconds integer) SECURITY DEFINER; | ||
ALTER function net.http_post(url text, body jsonb, params jsonb, headers jsonb, timeout_milliseconds integer) SECURITY DEFINER; | ||
|
||
ALTER function net.http_get(url text, params jsonb, headers jsonb, timeout_milliseconds integer) SET search_path = net; | ||
ALTER function net.http_post(url text, body jsonb, params jsonb, headers jsonb, timeout_milliseconds integer) SET search_path = net; | ||
|
||
REVOKE ALL ON FUNCTION net.http_get(url text, params jsonb, headers jsonb, timeout_milliseconds integer) FROM PUBLIC; | ||
REVOKE ALL ON FUNCTION net.http_post(url text, body jsonb, params jsonb, headers jsonb, timeout_milliseconds integer) FROM PUBLIC; | ||
|
||
GRANT EXECUTE ON FUNCTION net.http_get(url text, params jsonb, headers jsonb, timeout_milliseconds integer) TO supabase_functions_admin, postgres, anon, authenticated, service_role; | ||
GRANT EXECUTE ON FUNCTION net.http_post(url text, body jsonb, params jsonb, headers jsonb, timeout_milliseconds integer) TO supabase_functions_admin, postgres, anon, authenticated, service_role; | ||
END IF; | ||
END; | ||
$$; | ||
COMMENT ON FUNCTION extensions.grant_pg_net_access IS 'Grants access to pg_net'; | ||
|
||
DO | ||
$$ | ||
BEGIN | ||
IF NOT EXISTS ( | ||
SELECT 1 | ||
FROM pg_event_trigger | ||
WHERE evtname = 'issue_pg_net_access' | ||
) THEN | ||
CREATE EVENT TRIGGER issue_pg_net_access ON ddl_command_end WHEN TAG IN ('CREATE EXTENSION') | ||
EXECUTE PROCEDURE extensions.grant_pg_net_access(); | ||
END IF; | ||
END | ||
$$; | ||
|
||
ALTER function supabase_functions.http_request() SECURITY DEFINER; | ||
ALTER function supabase_functions.http_request() SET search_path = supabase_functions; | ||
REVOKE ALL ON FUNCTION supabase_functions.http_request() FROM PUBLIC; | ||
GRANT EXECUTE ON FUNCTION supabase_functions.http_request() TO postgres, anon, authenticated, service_role; | ||
|
||
|
||
-- migrate:down |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.