Add support for store access type infomation #192
Conversation
| if (reservedNames.has(nm)) continue; | ||
|
|
||
| this.appendScriptWithoutOffset( | ||
| `declare let $${nm}: Parameters<Parameters<(typeof ${nm})["subscribe"]>[0]>[0];`, |
There was a problem hiding this comment.
What if there is already an identifier named $nm or it's already declared by the user manually?
This could be uncommon, but before this PR this could happen if the user want to workaround this issue, then this PR would break that.
There was a problem hiding this comment.
I checked the edge case and it didn't seem to be a problem.
https://github.com/ota-meshi/svelte-eslint-parser/blob/store-type/tests/fixtures/parser/ast/ts-store01-type-output.svelte
Also, the svelte compiler doesn't seem to allow you to declare variables that start with $ yourself.
<script>
let name = 'world';
const $n = name
</script>
<h1>Hello {name}!</h1>There was a problem hiding this comment.
Does script with lang="ts" + user defined declare const $n: xxx works the same?
There was a problem hiding this comment.
I added a test case to check that edge case. That doesn't seem to be a problem either 😉.
There was a problem hiding this comment.
Wow, that is a bit of surprise to me
https://www.typescriptlang.org/play?#code/CYUwxgNghgTiAEYD2A7AzgF3gEigLnkxgEsUBzAKFElgWXS1wKNMqA
There was a problem hiding this comment.
OK, it should due to
tokens.length = 0
comments.length = 0
removeAllScope(node, result)I just learned a lot from this PR!
close #191