Skip to content

WIP: add id support for future svelte version #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

WIP: add id support for future svelte version #124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6630121
WIP: add hash support
May 18, 2020
425a426
Future-proof version selector & access minor version
May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const VirtualModules = require('./lib/virtual');
const hotApi = require.resolve('./lib/hot-api.js');

const { version } = require('svelte/package.json');
const major_version = +version[0];
const [major_version, minor_version] = version.split('.')
const { compile, preprocess } = major_version >= 3
? require('svelte/compiler')
: require('svelte');
Expand All @@ -15,8 +15,7 @@ const pluginOptions = {
hotReload: true,
hotOptions: true,
preprocess: true,
emitCss: true,

emitCss: true,
// legacy
onwarn: true,
shared: true,
Expand Down Expand Up @@ -122,6 +121,9 @@ module.exports = function(source, map) {

if (major_version >= 3) {
// TODO anything?
if(isServer) { //do minor version check here to see ensure if svelte has 'hash' option enabled
compileOptions.hash = hash(this.request)
}
} else {
compileOptions.shared = options.shared || 'svelte/shared.js';
compileOptions.name = capitalize(sanitize(compileOptions.filename));
Expand Down