issue-4850: fix extensions 'x-' prefix decoration for oas 3.1 #4880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frantuma
requested changes
Apr 28, 2025
There was a problem hiding this comment.
The code changes do update the logic to use the prefix also for 3.1, but this is applied regardless of the "target". It includes scenario where the extension is set to a Schema (JSON Schema), for which the prefix is not needed and would therefore keep the logic for openapi31 before the chance
Possibly adding a parameter to the method like usePrefix (applied to openapi31 only, current method kept for backward compatibility) is the way to go, and see in callers which one to call
djankows
force-pushed
the
issue-4850
branch
2 times, most recently
from
f18513f to
eb1dc70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.