[lldb][NFC] Remove vestigial downstream changes related to ThreadPlan migration #10000
Conversation
felipepiovezan
requested review from
kastiglione,
adrian-prantl and
jimingham
|
@swift-ci test |
felipepiovezan
changed the title
|
@felipepiovezan are there any remaining divergence related to swift async thread plans compared to upstream or are we matching upstream now ? |
AFAICT, we're matching it. But there could be changes in other files that I missed... |
|
Is this understanding correct: this change isn't doing anything, it's entirely undoing? |
That's right. Furthermore, it is NFC, this code is never reached. |
There was a problem hiding this comment.
LGTM. The only possibly NFC bit is moving DoTraceLog from after ShouldStopSyncronous to after. I can't see how that would matter, however.
The GetTID, etc. on ThreadPlan and ThreadPlanStack are theoretically useful, but GetThread().GetTID() isn't much harder, so I don't think we need to preserve them either.
LGTM
felipepiovezan
force-pushed
the
felipe/remove_migration_customizations
branch
from
0807bf3 to
b661766
Compare
The initial implementation of swift async stepping involved migrating
ThreadPlans from thread to thread. With the OS plugins introduced in
[1], this is no longer needed and the associated code is dead.
To find the relevant diffs, files were compared with their
upstream counterparts, and code mentioning the following concepts was
deleted:
* "synchronizing plans",
* "detached plans",
* "setting TIDs on a thread plan",
* "activating a thread plan stack".
The storage for thread plan stacks had been substantially changed
downstream to allow for the concepts above. This patch restores the
original storage data structures.
These were the files compared:
* ThreadPlanStack{.cpp, .h}
* ThreadPlan{.cpp, .h}
* Process{.cpp, .h}
[1]: swiftlang#9839
felipepiovezan
force-pushed
the
felipe/remove_migration_customizations
branch
from
b661766 to
c8c7df7
Compare
|
rebased |
|
@swift-ci test |
|
@swift-ci test windows platform |
The initial implementation of swift async stepping involved migrating ThreadPlans from thread to thread. With the OS plugins introduced in 1, this is no longer needed and the associated code is dead.
To find the relevant diffs, files were compared with their upstream counterparts, and code mentioning the following concepts was deleted:
The storage for thread plan stacks had been substantially changed downstream to allow for the concepts above. This patch restores the original storage data structures.
These were the files compared: