[lldb] Temporarily disable actor state test #10451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test added in "Add summary formatter for DefaultActorStorage (swiftlang#10388)" is checking the actor's state, but it is failing sometimes. Temporarily disable until Dave can look into this, to unblock CI/PR testing. rdar://148754221
|
@swift-ci test |
felipepiovezan
approved these changes
Apr 8, 2025
|
Yeah if the test was flakey I wasn't sure if it's safe to run anywhere, so i'd be adding skipifDarwin, skipifWindows, skipifLinux. maybe that is the better approach. |
This reverts commit 937c185.
The test added in "Add summary formatter for DefaultActorStorage (swiftlang#10388)" is checking the actor's state, but it is failing sometimes. Temporarily disable until Dave can look into this, to unblock CI/PR testing. rdar://148754221
|
@swift-ci test |
jasonmolenda
added a commit
to jasonmolenda/llvm-project
that referenced
this pull request
Apr 8, 2025
* [lldb] Temporarily disable actor state test The test added in "Add summary formatter for DefaultActorStorage (swiftlang#10388)" is checking the actor's state, but it is failing sometimes. Temporarily disable until Dave can look into this, to unblock CI/PR testing. rdar://148754221 (cherry picked from commit 0b855f5)
adrian-prantl
added a commit
that referenced
this pull request
Apr 8, 2025
…-skip-swift-actors-test-62 [lldb] Temporarily disable actor state test (#10451)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test added in "Add summary formatter for DefaultActorStorage (#10388)" is checking the actor's state, but it is failing sometimes. Temporarily disable until Dave can look into this, to unblock CI/PR testing.
rdar://148754221