Skip to content

[lldb/Symbol] Make TypeSystemSwift::GetTypeFromMangledTypename virtual (NFC) #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lldb/include/lldb/Symbol/SwiftASTContext.h
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ class TypeSystemSwift : public TypeSystem {
lldb::opaque_compiler_type_t type, Stream *s,
bool print_help_if_available, bool print_extensions_if_available,
lldb::DescriptionLevel level = lldb::eDescriptionLevelFull) = 0;
virtual CompilerType
GetTypeFromMangledTypename(ConstString mangled_typename) = 0;

/// Unavailable hardcoded functions that don't make sense for Swift.
/// \{
Expand Down Expand Up @@ -277,7 +279,8 @@ class TypeSystemSwiftTypeRef : public TypeSystemSwift {
swift::CanType GetCanonicalSwiftType(CompilerType compiler_type);
swift::Type GetSwiftType(CompilerType compiler_type);
CompilerType ReconstructType(CompilerType type);
CompilerType GetTypeFromMangledTypename(ConstString mangled_typename);
CompilerType
GetTypeFromMangledTypename(ConstString mangled_typename) override;

// PluginInterface functions
ConstString GetPluginName() override;
Expand Down Expand Up @@ -748,7 +751,8 @@ class SwiftASTContext : public TypeSystemSwift {
/// components up in Swift modules.
swift::TypeBase *ReconstructType(ConstString mangled_typename);
swift::TypeBase *ReconstructType(ConstString mangled_typename, Status &error);
CompilerType GetTypeFromMangledTypename(ConstString mangled_typename);
CompilerType
GetTypeFromMangledTypename(ConstString mangled_typename) override;

// Retrieve the Swift.AnyObject type.
CompilerType GetAnyObjectType();
Expand Down