Downgrade the TypeSystemSwiftTypeRef string validation errors #1331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the always-qualify mode is turned off, TyperPrinter::shouldPrintFullyQualified() insists on never printing qualifiers for types that come from Clang modules, but the way this is implemented this rule also fires for types from SDK overlays, which are technically Swift modules. Because of this the TypeSystemSwiftTyperef variant occasionally emits more-qualified names than the SwiftASTContext variant. Fixing this is so complex that it isn't worth the effort. It would be better to generally switch to a representation where all non-local types are always qualified. rdar://problem/63700540
to warnings. The remaining divergences are mostly cosmetic in nature and costly to fix. For testing purposes the code can be compiled with -DSTRICT_VALIDATION to retain the old behavior.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to warnings. The remaining divergences are mostly cosmetic in nature
and costly to fix. For testing purposes the code can be compiled with
-DSTRICT_VALIDATION to retain the old behavior.