Skip to content

[CMake] BUILD_SHARED_LIBS fixes #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2020
Merged

[CMake] BUILD_SHARED_LIBS fixes #1555

merged 1 commit into from
Jul 27, 2020

Conversation

davezarzycki
Copy link

No description provided.

@davezarzycki
Copy link
Author

@swift-ci please test platform

compnerd
compnerd approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are fine, but to verify, these are due to the swift changes?

You probably want to mirror these to apple/stable/20200714 for the rebranch.

@davezarzycki
Copy link
Author

I just haven't built with BUILD_SHARED_LIBS in a while. These problems tend to pile up and I think I'm the only person testing this Swift build setup. And ya, the master rebranch will need retesting.

@davezarzycki davezarzycki merged commit 1008519 into swiftlang:apple/stable/20200108 Jul 27, 2020
@davezarzycki davezarzycki deleted the build_shared_libs_fixes branch July 27, 2020 14:59
@davezarzycki
Copy link
Author

I guess said differently, I try to always verify that top-of-tree LLVM still successfully builds with BUILD_SHARED_LIBS before submitting a patch to Apple's fork. Sometimes LLVM proper can go a few days where BUILD_SHARED_LIBS is broken before it is fixed because very few if any LLVM bots test with BUILD_SHARED_LIBS enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@gottesmm gottesmm Awaiting requested review from gottesmm

@hyp hyp Awaiting requested review from hyp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davezarzycki @compnerd