[repl_swift] Delete codesigning override

[vedantk]

The OSS package build reports lldb-macosx-arm64/bin/repl_swift: is already signed.

It looks like the codesigning override for repl_swift is causing the binary to be signed twice.

[vedantk]

@swift-ci Please Build Toolchain macOS Platform

[vedantk]

@swift-ci test

[kastiglione]

The signing was introduced in 400559d "[CMake] install-distribution support for swift-lldb on Darwin". Are we sure that it can be removed?

[vedantk]

The signing was introduced in 400559d "[CMake] install-distribution support for swift-lldb on Darwin". Are we sure that it can be removed?

Not yet, I'm running ./utils/build-toolchain test locally to verify.

But, I suspect it can be removed. We don't override LLVM_CODESIGNING_IDENTITY for other distribution components. If codesigning is required for a local (development) build, a -DLLVM_CODESIGNING_IDENTITY should be passed at CMake configure time, and add_lldb_tool should take care of applying the signing. For a toolchain/package build, the toolchain-codesign tool should take care of signing.

[vedantk]

Looks like the linker is ad hoc signing Apple Silicon binaries by default - this explains why the error doesn't pop up on x86_64.

So to recap:

• For a local build on Apple Silicon, no LLVM_CODESIGNING_IDENTITY is required
• For a local build on x86, if the OS requires codesigning, -DLLVM_CODESIGNING_IDENTITY should be specified at CMake configure time
• We don't need to ad hoc sign for the embedded build (the signature is added in a post-build step)

[fredriss]

@vedantk I haven't checked if that's the case here, but one reason to add explicit code signing to a binary is to be able to give it entitlements. You cannot add entitlements without a code signature. I wouldn't be surprised if repl_swift needs entitlements .

[vedantk]

@fredriss I see. It looks like we do add entitlements for debugserver, but not for repl_swift.