Skip to content

Revert "[CodeExtractor] Don't create bitcasts when inserting lifetime markers (NFCI)" #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2020
Merged

Revert "[CodeExtractor] Don't create bitcasts when inserting lifetime markers (NFCI)" #2025

merged 2 commits into from
Oct 22, 2020

Conversation

vedantk
Copy link

@vedantk vedantk commented Oct 22, 2020

  • Revert "[CodeExtractor] Don't create bitcasts when inserting lifetime markers (NFCI)"
  • [test] HotColdSplit: cover use of opaque pointer type

@vedantk
Revert "[CodeExtractor] Don't create bitcasts when inserting lifetime…
e548751 
… markers (NFCI)"

This reverts commit 26ee8af.

It's necessary to insert bitcast the pointer operand of a lifetime
marker if it has an opaque pointer type.

rdar://70560161
(cherry picked from commit 099bffe)
@vedantk
[test] HotColdSplit: cover use of opaque pointer type
d5be1aa 
Add a test to cover the case where an extracted block contains a
lifetime marker for a pointer with an opaque type.

(cherry picked from commit da27beb)
@vedantk
Copy link
Author

vedantk commented Oct 22, 2020

@swift-ci test macOS

@vedantk vedantk merged commit 1bad10b into swiftlang:apple/stable/20200714 Oct 22, 2020
@vedantk vedantk deleted the eng/PR-70560161 branch October 22, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vedantk